On 04.09.25 18:45, Alex Deucher wrote:
> Commit b61badd20b44 ("drm/amdgpu: fix usage slab after free")
> reordered when amdgpu_fence_driver_sw_fini() was called after
> that patch, amdgpu_fence_driver_sw_fini() effectively became
> a no-op as the sched entities we never freed because the
> ring pointers were already set to NULL. Remove the NULL
> setting.
>
> Reported-by: Lin.Cao <[email protected]>
> Cc: Vitaly Prosyak <[email protected]>
> Cc: Christian König <[email protected]>
> Fixes: b61badd20b44 ("drm/amdgpu: fix usage slab after free")
> Signed-off-by: Alex Deucher <[email protected]>
Reviewed-by: Christian König <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> index 725d6437fe8e3..375f99082b407 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> @@ -421,8 +421,6 @@ void amdgpu_ring_fini(struct amdgpu_ring *ring)
> dma_fence_put(ring->vmid_wait);
> ring->vmid_wait = NULL;
> ring->me = 0;
> -
> - ring->adev->rings[ring->idx] = NULL;
> }
>
> /**
