On Fri, Sep 19, 2025 at 2:54 AM Prike Liang <prike.li...@amd.com> wrote:
>
> It should return an error code if userq VA validation fails.
>
> Fixes: 9e46b8bb0539 ("drm/amdgpu: validate userq buffer virtual
> address and size")
>
> Signed-off-by: Prike Liang <prike.li...@amd.com>
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 5ab4ee26b825..3bbe1001fda1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -71,6 +71,7 @@ int amdgpu_userq_input_va_validate(struct amdgpu_vm *vm,
> u64 addr,
> return 0;
> }
>
> + r = -EINVAL;
> out_err:
> amdgpu_bo_unreserve(vm->root.bo);
> return r;
> @@ -508,6 +509,7 @@ amdgpu_userq_create(struct drm_file *filp, union
> drm_amdgpu_userq *args)
> if (amdgpu_userq_input_va_validate(&fpriv->vm, args->in.queue_va,
> args->in.queue_size) ||
> amdgpu_userq_input_va_validate(&fpriv->vm, args->in.rptr_va,
> AMDGPU_GPU_PAGE_SIZE) ||
> amdgpu_userq_input_va_validate(&fpriv->vm, args->in.wptr_va,
> AMDGPU_GPU_PAGE_SIZE)) {
> + r = -EINVAL;
> kfree(queue);
> goto unlock;
> }
> --
> 2.34.1
>
