On Thu, Sep 25, 2025 at 3:39 PM Mario Limonciello <mario.limoncie...@amd.com> wrote: > > [Why] > Not all renoir hardware supports secure display. If the TA is present > but the feature isn't supported it will fail to load or send commands. > This shows ERR messages to the user that make it seems like there is > a problem. > > [How] > Check the resp_status of the context to see if there was an error > before trying to send any secure display commands. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1415 > Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
I think the tricky part is that we want it to throw an error on a system where it is supported so the user knows something is wrong. Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index 693357caa9a8..70d4bfb13f46 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > @@ -2356,6 +2356,9 @@ static int psp_securedisplay_initialize(struct > psp_context *psp) > } else > return ret; > > + if (psp->securedisplay_context.context.resp_status) > + return 0; > + > mutex_lock(&psp->securedisplay_context.mutex); > > psp_prep_securedisplay_cmd_buf(psp, &securedisplay_cmd, > -- > 2.51.0 >
