Re: [PATCH] drm/amdgpu/userq: Fix reading timeline points in wait ioctl

[David Rosca]

Cc Christian

On 15. 09. 25 8:20, David Rosca wrote:

Use correct u64 type.

Signed-off-by: David Rosca <david.ro...@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 95e91d1dc58a..729f0f358398 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -637,7 +637,8 @@ int amdgpu_userq_signal_ioctl(struct drm_device *dev, void 
*data,
  int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data,
                            struct drm_file *filp)
  {
-       u32 *syncobj_handles, *timeline_points, *timeline_handles, 
*bo_handles_read, *bo_handles_write;
+       u32 *syncobj_handles, *timeline_handles, *bo_handles_read, 
*bo_handles_write;
+       u64 *timeline_points;
        u32 num_syncobj, num_read_bo_handles, num_write_bo_handles;
        struct drm_amdgpu_userq_fence_info *fence_info = NULL;
        struct drm_amdgpu_userq_wait *wait_info = data;
@@ -682,7 +683,7 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void 
*data,
        }

timeline_points = memdup_user(u64_to_user_ptr(wait_info->syncobj_timeline_points),

-                                     sizeof(u32) * num_points);
+                                     sizeof(u64) * num_points);
        if (IS_ERR(timeline_points)) {
                r = PTR_ERR(timeline_points);
                goto free_timeline_handles;