[Public] Good catch. Will change the comments before committing.
Thanks, Lijo -----Original Message----- From: Kamal, Asad <[email protected]> Sent: Wednesday, October 8, 2025 11:25 AM To: Lazar, Lijo <[email protected]>; [email protected] Cc: Zhang, Hawking <[email protected]>; Deucher, Alexander <[email protected]> Subject: RE: [PATCH] drm/amdgpu: Skip SDMA suspend during mode-2 reset [AMD Official Use Only - AMD Internal Distribution Only] With minor comment and patch description changes Reviewed-by: Asad Kamal <[email protected]> Thanks & Regards Asad -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Lijo Lazar Sent: Wednesday, October 8, 2025 10:34 AM To: [email protected] Cc: Zhang, Hawking <[email protected]>; Deucher, Alexander <[email protected]>; Kamal, Asad <[email protected]> Subject: [PATCH] drm/amdgpu: Skip SDMA suspend during mode-2 reset For SDMA IP versions > v4.4.2, firmware will take care of quiescing SDMA before mode-2 reset. AK: Please change it as >= 4.4.2, same for code comment below Signed-off-by: Lijo Lazar <[email protected]> --- drivers/gpu/drm/amd/amdgpu/aldebaran.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c b/drivers/gpu/drm/amd/amdgpu/aldebaran.c index 9569dc16dd3d..0007d00b9e8f 100644 --- a/drivers/gpu/drm/amd/amdgpu/aldebaran.c +++ b/drivers/gpu/drm/amd/amdgpu/aldebaran.c @@ -88,6 +88,10 @@ static int aldebaran_mode2_suspend_ip(struct amdgpu_device *adev) uint32_t ip_block; int r, i; + /* Skip suspend of SDMA IP versions > 4.4.2. They are multi-aid */ + if (adev->aid_mask) + ip_block_mask &= ~BIT(AMD_IP_BLOCK_TYPE_SDMA); + amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); -- 2.49.0
