[AMD Official Use Only - AMD Internal Distribution Only] Looks good to me. Thanks for the patch!
Reviewed-by: Robert Liu <[email protected]> -----Original Message----- From: Alex Deucher <[email protected]> Sent: Friday, October 3, 2025 4:11 PM To: Kuehling, Felix <[email protected]> Cc: [email protected]; Liu, Robert <[email protected]> Subject: Re: [PATCH] drm/amdkfd: Fix two comments in kfd_ioctl.h Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Oct 3, 2025 at 4:09 PM Felix Kuehling <[email protected]> wrote: > > Queue read and write pointers are "to KFD", not "from KFD". > > Suggested-by: Robert Liu <[email protected]> > Signed-off-by: Felix Kuehling <[email protected]> Reviewed-by: Alex Deucher <[email protected]> > --- > include/uapi/linux/kfd_ioctl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/kfd_ioctl.h > b/include/uapi/linux/kfd_ioctl.h index 04c7d283dc7d7..5d1727a6d0405 > 100644 > --- a/include/uapi/linux/kfd_ioctl.h > +++ b/include/uapi/linux/kfd_ioctl.h > @@ -67,8 +67,8 @@ struct kfd_ioctl_get_version_args { > > struct kfd_ioctl_create_queue_args { > __u64 ring_base_address; /* to KFD */ > - __u64 write_pointer_address; /* from KFD */ > - __u64 read_pointer_address; /* from KFD */ > + __u64 write_pointer_address; /* to KFD */ > + __u64 read_pointer_address; /* to KFD */ > __u64 doorbell_offset; /* from KFD */ > > __u32 ring_size; /* to KFD */ > -- > 2.34.1 >
