On 10/20, Rodrigo Siqueira wrote: > When trying to unload amdgpu in the SteamDeck (TTY mode), the following > set of errors happens and the system gets unstable: > > [..] > [drm] Initialized amdgpu 3.64.0 for 0000:04:00.0 on minor 0 > amdgpu 0000:04:00.0: [drm:amdgpu_ib_ring_tests [amdgpu]] *ERROR* IB test > failed on gfx_0.0.0 (-110). > amdgpu 0000:04:00.0: amdgpu: ib ring test failed (-110). > [..] > amdgpu 0000:04:00.0: amdgpu: SMU: I'm not done with your previous command: > SMN_C2PMSG_66:0x0000001E SMN_C2PMSG_82:0x00000000 > amdgpu 0000:04:00.0: amdgpu: Failed to disable gfxoff! > amdgpu 0000:04:00.0: amdgpu: SMU: I'm not done with your previous command: > SMN_C2PMSG_66:0x0000001E SMN_C2PMSG_82:0x00000000 > amdgpu 0000:04:00.0: amdgpu: Failed to disable gfxoff! > [..] > > When the driver initializes the GPU, the PSP validates all the firmware > loaded, and after that, it is not possible to load any other firmware > unless the device is reset. What is happening in the load/unload > situation is that PSP halts the GC engine because it suspects that > something is amiss. To address this issue, this commit ensures that the > GPU is reset (mode 2 reset) in the unload sequence. > > Suggested-by: Alex Deucher <[email protected]> > Signed-off-by: Rodrigo Siqueira <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 0d5585bc3b04..0a7bcb2d5a50 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3649,6 +3649,13 @@ static int amdgpu_device_ip_fini_early(struct > amdgpu_device *adev) > "failed to release exclusive mode on fini\n"); > } > > + /* Reset the device before entirely removing it to avoid load issues > + * caused by firmware validation. > + */ > + r = amdgpu_asic_reset(adev); > + if (r) > + dev_err(adev->dev, "asic reset on %s failed\n", __func__); > + > return 0; > } > > -- > 2.51.0 >
Hi Alex, If this change is okay with you, may I send a revert for the change below? 72a98763b473890e6605604bfcaf71fc212b4720 - drm/amd: fix gfx hang on renoir in IGT reload test The above change adds GPU reset during load time. Thanks -- Rodrigo Siqueira
