[AMD Official Use Only - AMD Internal Distribution Only] this patch is Reviewed-by: Jesse Zhang <[email protected]>
> -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Alex > Deucher > Sent: Thursday, October 23, 2025 5:20 AM > To: [email protected] > Cc: Deucher, Alexander <[email protected]> > Subject: [PATCH] drm/amdgpu: fix possible fence leaks from job structure > > If we don't end up initializing the fences, free then when we free the job. > > Fixes: db36632ea51e ("drm/amdgpu: clean up and unify hw fence handling") > Signed-off-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > index 3d396ab625f33..8ad8b16e96760 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > @@ -295,6 +295,11 @@ static void amdgpu_job_free_cb(struct drm_sched_job > *s_job) > > amdgpu_sync_free(&job->explicit_sync); > > + if (!job->hw_fence->base.ops) > + kfree(job->hw_fence); > + if (!job->hw_vm_fence->base.ops) > + kfree(job->hw_vm_fence); > + > kfree(job); > } > > @@ -324,6 +329,11 @@ void amdgpu_job_free(struct amdgpu_job *job) > if (job->gang_submit != &job->base.s_fence->scheduled) > dma_fence_put(job->gang_submit); > > + if (!job->hw_fence->base.ops) > + kfree(job->hw_fence); > + if (!job->hw_vm_fence->base.ops) > + kfree(job->hw_vm_fence); > + > kfree(job); > } > > -- > 2.51.0
