[AMD Official Use Only - AMD Internal Distribution Only]
-----Original Message-----
From: Chai, Thomas <[email protected]>
Sent: Wednesday, October 29, 2025 10:43 AM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>; Li,
Candice <[email protected]>; Wang, Yang(Kevin) <[email protected]>; Yang,
Stanley <[email protected]>; Su, Joe <[email protected]>; Chai, Thomas
<[email protected]>; kernel test robot <[email protected]>; Zhou1, Tao
<[email protected]>
Subject: [PATCH] drm/amd/ras: Fix the error of undefined reference to
`__udivdi3'
Fix the error:
drivers/gpu/drm/amd/amdgpu/../ras/ras_mgr/amdgpu_ras_mgr.c:132:undefined
reference to `__udivdi3'
Fixs:b5bae0f01786d("drm/amd/ras: Add amdgpu ras management function")
Reported-by: kernel test robot <[email protected]>
Closes:https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: YiPeng Chai <[email protected]>
Reviewed-by: Tao Zhou <[email protected]>
---
drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
index 8007e49951d8..d09c4a75a7f4 100644
--- a/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
+++ b/drivers/gpu/drm/amd/ras/ras_mgr/amdgpu_ras_mgr.c
@@ -37,7 +37,7 @@
#define MAX_XCD_NUM_PER_AID 2
/* typical ECC bad page rate is 1 bad page per 100MB VRAM */
-#define ESTIMATE_BAD_PAGE_THRESHOLD(size) ((size)/(100 * 1024 *
1024ULL))
+#define TYPICAL_ECC_BAD_PAGE_RATE (100 * 1024 * 1024ULL)
[kevin]:
Please use Linux SZ_* macros instead of hardcoded value to make code more
readable.
e.g: 100ULL * SZ_1M
The patch is Reviewed-by: Yang Wang <[email protected]>
Best Regards,
Kevin
#define COUNT_BAD_PAGE_THRESHOLD(size) (((size) >> 21) << 4)
@@ -129,7 +129,7 @@ static int amdgpu_ras_mgr_init_eeprom_config(struct
amdgpu_device *adev,
*/
if (amdgpu_bad_page_threshold == NONSTOP_OVER_THRESHOLD)
eeprom_cfg->eeprom_record_threshold_count =
-
ESTIMATE_BAD_PAGE_THRESHOLD(adev->gmc.mc_vram_size);
+ div64_u64(adev->gmc.mc_vram_size,
TYPICAL_ECC_BAD_PAGE_RATE);
else if (amdgpu_bad_page_threshold == WARN_NONSTOP_OVER_THRESHOLD)
eeprom_cfg->eeprom_record_threshold_count =
COUNT_BAD_PAGE_THRESHOLD(RAS_RESERVED_VRAM_SIZE_DEFAULT);
--
2.34.1
