[AMD Official Use Only - AMD Internal Distribution Only] Thanks, Kevin Will remove this macro before submitting
-----Original Message----- From: Wang, Yang(Kevin) <[email protected]> Sent: Wednesday, October 29, 2025 5:06 PM To: Xie, Patrick <[email protected]>; [email protected] Cc: Zhou1, Tao <[email protected]>; Xie, Patrick <[email protected]> Subject: RE: [PATCH 02/10] drm/amd/pm: remove smu response check [AMD Official Use Only - AMD Internal Distribution Only] - case SMU_RESP_DEBUG_END: Please remove this macro together, with that fixed, the patch is Reviewed-by: Yang Wang <[email protected]> Best Regards, Kevin -----Original Message----- From: amd-gfx <[email protected]> On Behalf Of Gangliang Xie Sent: Wednesday, October 29, 2025 4:48 PM To: [email protected] Cc: Zhou1, Tao <[email protected]>; Xie, Patrick <[email protected]> Subject: [PATCH 02/10] drm/amd/pm: remove smu response check Remove switch entry for SMU_RESP_DEBUG_END to process it in default entry as a generic error, because its meaning may varies among different socs. Signed-off-by: Gangliang Xie <[email protected]> --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c index a8961a8f5c42..eea5ff69e5ed 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c @@ -168,10 +168,6 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu, "SMU: I'm very busy for your command: index:%d param:0x%08X message:%s", msg_index, param, message); break; - case SMU_RESP_DEBUG_END: - dev_err_ratelimited(adev->dev, - "SMU: I'm debugging!"); - break; case SMU_RESP_UNEXP: if (amdgpu_device_bus_status_check(smu->adev)) { /* print error immediately if device is off the bus */ -- 2.34.1
