Compact some very long and repetitive lines of code by caching the respective object in local variables. This is a concept which is already used at places, but not consistently so.
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-27 (-27) Function old new delta vcn_v3_0_ring_patch_cs_in_place 987 960 -27 Total: Before=8977359, After=8977332, chg -0.00% Signed-off-by: Tvrtko Ursulin <[email protected]> --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index 3ee79a44ee40..414fd644fe26 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c @@ -1991,6 +1991,8 @@ static int vcn_v3_0_ring_patch_cs_in_place(struct amdgpu_cs_parser *p, struct amdgpu_ib *ib) { struct amdgpu_ring *ring = amdgpu_job_ring(job); + struct amdgpu_vcn_reg *internal = + &ring->adev->vcn.inst[ring->me].internal; uint32_t msg_lo = 0, msg_hi = 0; unsigned i; int r; @@ -2003,11 +2005,11 @@ static int vcn_v3_0_ring_patch_cs_in_place(struct amdgpu_cs_parser *p, uint32_t reg = amdgpu_ib_get_value(ib, i); uint32_t val = amdgpu_ib_get_value(ib, i + 1); - if (reg == PACKET0(p->adev->vcn.inst[ring->me].internal.data0, 0)) { + if (reg == PACKET0(internal->data0, 0)) { msg_lo = val; - } else if (reg == PACKET0(p->adev->vcn.inst[ring->me].internal.data1, 0)) { + } else if (reg == PACKET0(internal->data1, 0)) { msg_hi = val; - } else if (reg == PACKET0(p->adev->vcn.inst[ring->me].internal.cmd, 0) && + } else if (reg == PACKET0(internal->cmd, 0) && val == 0) { r = vcn_v3_0_dec_msg(p, job, ((u64)msg_hi) << 32 | msg_lo); -- 2.48.0
