Re: [PATCH v2] drm/amd/pm: Add NULL check for power limit

[Lazar, Lijo]

On 11/6/2025 9:31 PM, Asad Kamal wrote:

Add NULL check for smu power limit pointer

v2: Update error code on failure (Lijo)

Signed-off-by: Asad Kamal <asad.ka...@amd.com>
---
  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c 
b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 8b49fb86c77b..4a2c3ad0c38a 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -2907,6 +2907,9 @@ int smu_get_power_limit(void *handle,
        if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled)
                return -EOPNOTSUPP;

+ if (!limit)

+               return -EINVAL;
+

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

        switch (pp_power_type) {
        case PP_PWR_TYPE_SUSTAINED:
                limit_type = SMU_DEFAULT_PPT_LIMIT;