[AMD Official Use Only - AMD Internal Distribution Only]

Seems straight-forward enough.

Reviewed-by: Kent Russell <[email protected]>



> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of Chen,
> Xiaogang
> Sent: Thursday, November 20, 2025 9:28 AM
> To: Chen, Xiaogang <[email protected]>; [email protected]
> Subject: Re: [PATCH] drm/amdgpu: Don't send warning when close drm obj if drm
> device has been unplug
>
>
> ping
>
> On 11/17/2025 12:52 PM, Xiaogang.Chen wrote:
> > From: Xiaogang Chen <[email protected]>
> >
> > During amdgpu_gem_object_close amdgpu driver cleans vm mapping for the
> closing
> > drm obj. If the correspondent adev has been unplug got error -ENODEV code. 
> > In
> > this case do not need send warning message.
> >
> > Signed-off-by: Xiaogang Chen<[email protected]>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > index e3f65977eeee..1b9a6b15b29f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > @@ -377,7 +377,7 @@ static void amdgpu_gem_object_close(struct
> drm_gem_object *obj,
> >             goto out_unlock;
> >
> >     r = amdgpu_vm_clear_freed(adev, vm, &fence);
> > -   if (unlikely(r < 0))
> > +   if (unlikely(r < 0) && !drm_dev_is_unplugged(adev_to_drm(adev)))
> >             dev_err(adev->dev, "failed to clear page "
> >                     "tables on GEM object close (%ld)\n", r);
> >     if (r || !fence)
> > @@ -387,7 +387,7 @@ static void amdgpu_gem_object_close(struct
> drm_gem_object *obj,
> >     dma_fence_put(fence);
> >
> >   out_unlock:
> > -   if (r)
> > +   if (r && !drm_dev_is_unplugged(adev_to_drm(adev)))
> >             dev_err(adev->dev, "leaking bo va (%ld)\n", r);
> >     drm_exec_fini(&exec);
> >   }

<<attachment: winmail.dat>>

Reply via email to