From: Dillon Varone <[email protected]>

[WHY&HOW]
If DMCUB is not initialized or FAMS2 is not supported, the
interface should not be called.

Reviewed-by: Sridevi Arvindekar <[email protected]>
Signed-off-by: Dillon Varone <[email protected]>
Signed-off-by: Roman Li <[email protected]>
---
 drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c 
b/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c
index 614d3e95de18..ce50e36a414b 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c
@@ -1774,7 +1774,8 @@ void dcn401_unblank_stream(struct pipe_ctx *pipe_ctx,
 void dcn401_hardware_release(struct dc *dc)
 {
        if (!dc->debug.disable_force_pstate_allow_on_hw_release) {
-               dc_dmub_srv_fams2_update_config(dc, dc->current_state, false);
+               if (dc->ctx->dmub_srv && dc->debug.fams2_config.bits.enable)
+                       dc_dmub_srv_fams2_update_config(dc, dc->current_state, 
false);
 
                /* If pstate unsupported, or still supported
                * by firmware, force it supported by dcn
@@ -1794,7 +1795,9 @@ void dcn401_hardware_release(struct dc *dc)
                        dc->clk_mgr->clks.p_state_change_support = false;
                        dc->clk_mgr->funcs->update_clocks(dc->clk_mgr, 
dc->current_state, true);
                }
-               dc_dmub_srv_fams2_update_config(dc, dc->current_state, false);
+
+               if (dc->ctx->dmub_srv && dc->debug.fams2_config.bits.enable)
+                       dc_dmub_srv_fams2_update_config(dc, dc->current_state, 
false);
        }
 }
 
-- 
2.34.1

Reply via email to