[Public] Can we try to keep it to <80 characters?
Kent > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Andrew > Martin > Sent: Wednesday, December 3, 2025 9:45 AM > To: [email protected] > Cc: Martin, Andrew <[email protected]> > Subject: [PATCH v5] drm/amdgpu: Ignored various return code > > The return code of a non void function should not be ignored. In cases > where we do not care, the code needs to suppress it. > > Signed-off-by: Andrew Martin <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +++----- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 8 ++++++-- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > index a2879d2b7c8e..02259886f93a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > @@ -312,8 +312,7 @@ int amdgpu_amdkfd_post_reset(struct amdgpu_device > *adev) > void amdgpu_amdkfd_gpu_reset(struct amdgpu_device *adev) > { > if (amdgpu_device_should_recover_gpu(adev)) > - amdgpu_reset_domain_schedule(adev->reset_domain, > - &adev->kfd.reset_work); > + (void)amdgpu_reset_domain_schedule(adev->reset_domain, &adev- > >kfd.reset_work); > } > > int amdgpu_amdkfd_alloc_gtt_mem(struct amdgpu_device *adev, size_t size, > @@ -714,9 +713,8 @@ void amdgpu_amdkfd_set_compute_idle(struct > amdgpu_device *adev, bool idle) > if (gfx_block != NULL) > gfx_block->version->funcs->set_powergating_state((void > *)gfx_block, state); > } > - amdgpu_dpm_switch_power_profile(adev, > - PP_SMC_POWER_PROFILE_COMPUTE, > - !idle); > + (void)amdgpu_dpm_switch_power_profile(adev, > PP_SMC_POWER_PROFILE_COMPUTE, !idle); > + > } > > bool amdgpu_amdkfd_is_kfd_vmid(struct amdgpu_device *adev, u32 vmid) > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > index 041237861107..66ded3c07eef 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > @@ -2796,8 +2796,12 @@ static int runtime_enable(struct kfd_process *p, > uint64_t > r_debug, > * SET_SHADER_DEBUGGER clears any stale process context data > * saved in MES. > */ > - if (pdd->dev->kfd->shared_resources.enable_mes) > - kfd_dbg_set_mes_debug_mode(pdd, > !kfd_dbg_has_cwsr_workaround(pdd->dev)); > + if (pdd->dev->kfd->shared_resources.enable_mes) { > + ret = kfd_dbg_set_mes_debug_mode( > + pdd, !kfd_dbg_has_cwsr_workaround(pdd->dev)); > + if (ret) > + return ret; > + } > } > > p->runtime_info.runtime_state = DEBUG_RUNTIME_STATE_ENABLED; > -- > 2.43.0
