On 12/9/25 02:25, Philip Yang wrote:
> With this bug MTYPE_UC 0x3 can not be updated to MTYPE_RW 0x1.
> 

We need a bit more text here. E.g. something like "Fix copy&paste error, that 
should have been an assignment instead of an or."

> CC stables.
> 
> cc: [email protected]
> Signed-off-by: Philip Yang <[email protected]>

With the commit message updated:

Reviewed-by: Christian König <[email protected]>

Regards,
Christian.

> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c 
> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> index 97a04e3171f2..205c34eb8d11 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
> @@ -1204,16 +1204,16 @@ static void gmc_v9_0_get_vm_pte(struct amdgpu_device 
> *adev,
>               *flags = AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_NC);
>               break;
>       case AMDGPU_VM_MTYPE_WC:
> -             *flags |= AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_WC);
> +             *flags = AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_WC);
>               break;
>       case AMDGPU_VM_MTYPE_RW:
> -             *flags |= AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_RW);
> +             *flags = AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_RW);
>               break;
>       case AMDGPU_VM_MTYPE_CC:
> -             *flags |= AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_CC);
> +             *flags = AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_CC);
>               break;
>       case AMDGPU_VM_MTYPE_UC:
> -             *flags |= AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_UC);
> +             *flags = AMDGPU_PTE_MTYPE_VG10(*flags, MTYPE_UC);
>               break;
>       }
>  

Reply via email to