On Thu, Jan 29, 2026 at 4:52 AM Timur Kristóf <[email protected]> wrote:
>
> On Thursday, January 29, 2026 5:39:35 AM Central European Standard Time Alex
> Deucher wrote:
> > Kernel gfx queues do not need to be reinitialized or
> > remapped after a reset. This fixes queue reset failures
> > on APUs.
> >
> > Fixes: b3e9bfd86658 ("drm/amdgpu/gfx11: add ring reset callbacks")
> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4789
> > Signed-off-by: Alex Deucher <[email protected]>
>
> The series is:
> Reviewed-by: Timur Kristóf <[email protected]>
> (including with Jesse's suggestion if you choose to implement that).
>
> I notice that gfx_v10_0_reset_kgq() also calls gfx_v10_0_kgq_init_queue(),
> should that call be removed as well or made conditional?
In my testing, gfx10 seems to require it, but I plan to look into it
deeper when I get a chance.
Alex
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index b5a2d09fc3469..489edf517f91c
> > 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> > @@ -6854,18 +6854,6 @@ static int gfx_v11_0_reset_kgq(struct amdgpu_ring
> > *ring, return r;
> > }
> >
> > - r = gfx_v11_0_kgq_init_queue(ring, true);
> > - if (r) {
> > - dev_err(adev->dev, "failed to init kgq\n");
> > - return r;
> > - }
> > -
> > - r = amdgpu_mes_map_legacy_queue(adev, ring, 0);
> > - if (r) {
> > - dev_err(adev->dev, "failed to remap kgq\n");
> > - return r;
> > - }
> > -
> > return amdgpu_ring_reset_helper_end(ring, timedout_fence);
> > }
>
>
>
>
