On 2/4/26 10:34, Sunil Khatri wrote:
> In low memory conditions, kmalloc can fail. In such conditions
> unlock the mutex for a clean exit.
>
> We do not need to amdgpu_bo_list_put as it's been handled in the
> amdgpu_cs_parser_fini.
>
> Fixes: 737da5363cc0 ("drm/amdgpu: update the functions to use amdgpu version
> of hmm")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Closes: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: Sunil Khatri <[email protected]>
Reviewed-by: Christian König <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index d591dce0f3b3..f3b5bcdbf2ae 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -892,8 +892,10 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser
> *p,
> struct amdgpu_bo *bo = e->bo;
>
> e->range = amdgpu_hmm_range_alloc(NULL);
> - if (unlikely(!e->range))
> - return -ENOMEM;
> + if (unlikely(!e->range)) {
> + r = -ENOMEM;
> + goto out_free_user_pages;
> + }
>
> r = amdgpu_ttm_tt_get_user_pages(bo, e->range);
> if (r)
