Re: [PATCH 10/12] drm/amdgpu: reorder IB schedule sequence

[Pierre-Eric Pelloux-Prayer]

Le 30/01/2026 à 18:30, Alex Deucher a écrit :

This reorders the IB schedule sequence to cleanly
separate the vm operation from the IB submission.
This makes the two independent so we can cleanly
associate each one with its respective fence.

Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-pra...@amd.com>

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 22 +++++++++++-----------
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |  7 +++++++
  2 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
index 1f60ccb8782ee..0932a093dee3d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -192,16 +192,6 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, struct 
amdgpu_job *job,
                dma_fence_put(tmp);
        }

- if ((ib->flags & AMDGPU_IB_FLAG_EMIT_MEM_SYNC) && ring->funcs->emit_mem_sync)

-               ring->funcs->emit_mem_sync(ring);
-
-       if (ring->funcs->emit_wave_limit &&
-           ring->hw_prio == AMDGPU_GFX_PIPE_PRIO_HIGH)
-               ring->funcs->emit_wave_limit(ring, true);
-
-       if (ring->funcs->insert_start)
-               ring->funcs->insert_start(ring);
-
        r = amdgpu_vm_flush(ring, job, need_pipe_sync);
        if (r) {
                amdgpu_ring_undo(ring);
@@ -210,6 +200,16 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, struct 
amdgpu_job *job,

amdgpu_ring_ib_begin(ring); + if (ring->funcs->insert_start)

+               ring->funcs->insert_start(ring);
+
+       if ((ib->flags & AMDGPU_IB_FLAG_EMIT_MEM_SYNC) && 
ring->funcs->emit_mem_sync)
+               ring->funcs->emit_mem_sync(ring);
+
+       if (ring->funcs->emit_wave_limit &&
+           ring->hw_prio == AMDGPU_GFX_PIPE_PRIO_HIGH)
+               ring->funcs->emit_wave_limit(ring, true);
+
        if (ring->funcs->emit_gfx_shadow && adev->gfx.cp_gfx_shadow)
                amdgpu_ring_emit_gfx_shadow(ring, job->shadow_va, job->csa_va, 
job->gds_va,
                                            job->init_shadow, vmid);
@@ -297,6 +297,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, struct 
amdgpu_job *job,
            ring->hw_prio == AMDGPU_GFX_PIPE_PRIO_HIGH)
                ring->funcs->emit_wave_limit(ring, false);

+ amdgpu_ring_ib_end(ring);

        /* Save the wptr associated with this fence.
         * This must be last for resets to work properly
         * as we need to save the wptr associated with this
@@ -305,7 +306,6 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, struct 
amdgpu_job *job,
         */
        amdgpu_fence_save_wptr(af);

- amdgpu_ring_ib_end(ring);

        amdgpu_ring_commit(ring);

return 0;

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 6a2ea200d90c8..ed0d450b08362 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -815,6 +815,10 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct 
amdgpu_job *job,
                return 0;

amdgpu_ring_ib_begin(ring);

+
+       if (ring->funcs->insert_start)
+               ring->funcs->insert_start(ring);
+
        if (ring->funcs->init_cond_exec)
                patch = amdgpu_ring_init_cond_exec(ring,
                                                   ring->cond_exe_gpu_addr);
@@ -891,6 +895,9 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct 
amdgpu_job *job,
                amdgpu_ring_emit_switch_buffer(ring);
        }

+ if (ring->funcs->insert_end)

+               ring->funcs->insert_end(ring);
+
        amdgpu_ring_ib_end(ring);
        return 0;
  }