On Thu, Feb 5, 2026 at 2:02 AM Perry Yuan <[email protected]> wrote:
>
> Introduce hardware detection, runtime state tracking and a
> kgd->ptl_ctrl() callback to enable/disable/query PTL via the
> PSP performance-monitor interface (commands 0xA0000000/1).
> The driver now exposes PTL capability to KFD and keeps the
> software state in sync with the hardware.
>
> Signed-off-by: Perry Yuan <[email protected]>
> Reviewed-by: Lijo Lazar <[email protected]>
> Acked-by: Alex Deucher <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 36 +++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> index ad4d442e7345..a970913ec66c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
> @@ -2370,11 +2370,45 @@ static int gfx_v9_4_3_hw_init(struct amdgpu_ip_block
> *ip_block)
> return r;
> }
>
> +static int gfx_v9_4_3_perf_monitor_ptl_init(struct amdgpu_device *adev, bool
> state)
Rather than state, call the parameter enable or something more obvious
as to what it's doing.
> +{
> + uint32_t fmt1, fmt2;
> + uint32_t ptl_state = state ? 1 : 0;
> + int r;
> +
> + if (amdgpu_ip_version(adev, GC_HWIP, 0) != IP_VERSION(9, 4, 4))
> + return -ENOTSUPP;
> +
> + if (!adev->psp.funcs)
> + return -EOPNOTSUPP;
> +
> + if (!adev->psp.ptl_hw_supported) {
> + fmt1 = GFX_FTYPE_I8;
> + fmt2 = GFX_FTYPE_BF16;
> + } else {
> + fmt1 = adev->psp.ptl_fmt1;
> + fmt2 = adev->psp.ptl_fmt2;
> + }
> +
> + /* initialize PTL with default formats: GFX_FTYPE_I8 & GFX_FTYPE_BF16
> */
> + r = psp_performance_monitor_hw(&adev->psp, PSP_PTL_PERF_MON_SET,
> &ptl_state,
> + &fmt1, &fmt2);
> + if (r)
> + return r;
> +
> + adev->psp.ptl_hw_supported = true;
> +
> + return 0;
> +}
> +
> static int gfx_v9_4_3_hw_fini(struct amdgpu_ip_block *ip_block)
> {
> struct amdgpu_device *adev = ip_block->adev;
> int i, num_xcc;
>
> + if (adev->psp.ptl_hw_supported)
> + gfx_v9_4_3_perf_monitor_ptl_init(adev, 0);
Use false rather than 0 here.
> +
> amdgpu_irq_put(adev, &adev->gfx.priv_reg_irq, 0);
> amdgpu_irq_put(adev, &adev->gfx.priv_inst_irq, 0);
> amdgpu_irq_put(adev, &adev->gfx.bad_op_irq, 0);
> @@ -2549,6 +2583,8 @@ static int gfx_v9_4_3_late_init(struct amdgpu_ip_block
> *ip_block)
> adev->gfx.ras->enable_watchdog_timer)
> adev->gfx.ras->enable_watchdog_timer(adev);
>
> + gfx_v9_4_3_perf_monitor_ptl_init(adev, 1);
Use true here rather than 1.
Alex
> +
> return 0;
> }
>
> --
> 2.34.1
>
