[AMD Official Use Only - AMD Internal Distribution Only]

Reveiwed-by : "Jesse Zhang <[email protected]>"

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of Srinivasan
> Shanmugam
> Sent: Thursday, February 5, 2026 8:27 PM
> To: Koenig, Christian <[email protected]>; Deucher, Alexander
> <[email protected]>
> Cc: [email protected]; SHANMUGAM, SRINIVASAN
> <[email protected]>
> Subject: [PATCH] drm/amdgpu: Fix parameter mismatch in
> amdgpu_userq_set_compute_mqd()
>
> Update the function documentation to match the current parameter list and 
> correctly
> describe compute_mqd.
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/mes_userqueue.c:308 function parameter
> 'compute_mqd' not described in 'amdgpu_userq_set_compute_mqd'
>
> Cc: Alex Deucher <[email protected]>
> Cc: Christian König <[email protected]>
> Signed-off-by: Srinivasan Shanmugam <[email protected]>
> Change-Id: I2f6efa8e9886106d6cdfcf0ff9ffb2576d8ba606
> ---
>  drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> index f4b3073cf968..24d102cb1474 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> @@ -296,12 +296,12 @@ static int mes_userq_detect_and_reset(struct
> amdgpu_device *adev,
>   * amdgpu_userq_set_compute_mqd - Parse compute MQD and update queue
> props
>   * @queue: Target user mode queue
>   * @props: Queue property structure to be updated
> - * @args: User queue input arguments
> - * @uq_mgr: User queue manager (for logging)
> + * @compute_mqd: User-provided compute MQD payload (GFX11) to
> + parse/validate
>   *
>   * This function only parses and validates user input, updating queue props
> - * (no hardware MQD configuration - that's handled in MES layer)
> - * Returns: 0 on success, negative error code on failure
> + * (no hardware MQD configuration - that's handled in MES layer).
> + *
> + * Return: 0 on success, negative error code on failure
>   */
>  static int amdgpu_userq_set_compute_mqd(struct amdgpu_usermode_queue
> *queue,
>                                       struct amdgpu_mqd_prop *props,
> --
> 2.34.1

Reply via email to