[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Koenig, Christian <[email protected]> > Sent: Friday, February 6, 2026 9:03 PM > To: SHANMUGAM, SRINIVASAN <[email protected]>; > Deucher, Alexander <[email protected]> > Cc: [email protected]; Dan Carpenter <[email protected]> > Subject: Re: [PATCH] drm/amdgpu: Fix missing unwind in amdgpu_ib_schedule() > error path > > On 2/6/26 15:24, Srinivasan Shanmugam wrote: > > If amdgpu_vm_flush() fails, amdgpu_ib_schedule() returns early after > > calling amdgpu_ring_undo(). This skips the common free_fence cleanup > > path. Other error paths were already changed to use goto free_fence, > > but this one was missed. > > In general good catch, but amdgpu_vm_flush() never fails :) > > I wanted to remove the return code after Alex has cleaned this up but haven't > got > the time for it yet. > > Maybe you can give that a try. It originates in amdgpu_fence_emit().
Hi Christian, Thanks for your feedback, proposed a follow-up for the same https://patchwork.freedesktop.org/patch/703635/ Thanks, Srini > > Thanks, > Christian.
