[AMD Official Use Only - AMD Internal Distribution Only] > -----Original Message----- > From: Koenig, Christian <[email protected]> > Sent: Monday, February 9, 2026 3:11 PM > To: SHANMUGAM, SRINIVASAN <[email protected]>; > Deucher, Alexander <[email protected]> > Cc: [email protected] > Subject: Re: [PATCH] drm/amdgpu: Don't propagate errors from > amdgpu_vm_flush() > > On 2/8/26 07:27, Srinivasan Shanmugam wrote: > > amdgpu_vm_flush() only returns an error when amdgpu_fence_emit() fails. > > You need to take a step further amdgpu_fence_emit() can't fail either. > > The fallback wait inside that function blocks forever until the fence signals > and that > should never happen in the job submission path in the first place.
Thanks Christian, understood. For amdgpu_fence_emit(), I will not add any recovery logic. I will keep only a WARN_ON_ONCE() and return early if it ever triggers. Please let me know if this approach is OK, and if you would like this as a follow-up patch. Regards, Srini > > Regards, > Christian.
