On 2/10/26 06:11, Srinivasan Shanmugam wrote: > dma_fence_wait(old, false) cannot return an error because it is not > interruptible. Drop the unreachable error handling in amdgpu_fence_emit(). > > Suggested-by: Christian König <[email protected]> > Cc: Alex Deucher <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > index 1054d66c54fa..01f347f59405 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c > @@ -141,10 +141,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct > amdgpu_fence *af, > rcu_read_unlock(); > > if (old) { > - r = dma_fence_wait(old, false); > + dma_fence_wait(old, false); > dma_fence_put(old); > - if (r) > - return r;
Please also drop the return code from amdgpu_fence_emit() and cleanup all callers since the function now can't fail any more. Apart from that looks good to me. Thanks, Christian. > } > } >
