[AMD Official Use Only - AMD Internal Distribution Only]

Felix, thanks for the reply. See comments inline

> -----Original Message-----
> From: Kuehling, Felix <[email protected]>
> Sent: Wednesday, February 11, 2026 4:11 PM
> To: [email protected]; Martin, Andrew
> <[email protected]>
> Cc: Cornwall, Jay <[email protected]>; Greathouse, Joseph
> <[email protected]>
> Subject: Re: [PATCH] drm/amdkfd: Disable MQD queue priority
>
>
> On 2026-02-02 05:53, Andrew Martin wrote:
> > This solves a "priority inversion" issue, caused by the language
>
> Why the quotes?

Consider them dropped from the next git commit,  it was just to highlight the 
phrase.
>
>
> > runtime making high-priority queues wait for activity on
> > lower-priority queues.
>
> Is this problem specific to GFX9? Otherwise, an equivalent fix should be
> implemented in other versions of the MQD manager as well.
>

No,  it is not specific to GFX9, so I will broaden the change on the next 
patch. I will get that out tomorrow.

>
> >
> > Signed-off-by: Andrew Martin <[email protected]>
> > ---
> >   drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
> > index dcf4bbfa641b..bc4ceba35908 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c
> > @@ -106,7 +106,7 @@ static void update_cu_mask(struct mqd_manager
> *mm, void *mqd,
> >   static void set_priority(struct v9_mqd *m, struct queue_properties *q)
> >   {
> >     m->cp_hqd_pipe_priority = pipe_priority_map[q->priority];
> > -   m->cp_hqd_queue_priority = q->priority;
> > +   /* m->cp_hqd_queue_priority = q->priority; */
>
> Please don't leave commented out lines in the code. That's what git
> history is for.
>
> Regards,
>    Felix
>
>
> >   }
> >
> >   static bool mqd_on_vram(struct amdgpu_device *adev)

Reply via email to