On Mon, 2026-03-02 at 20:25 -0800, Darrick J. Wong wrote: > On Mon, Mar 02, 2026 at 08:25:56PM -0500, Theodore Tso wrote: > > On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > > > The PRIino macro is a length modifier, not a complete format specifier. > > > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > > > This follows the pattern used by userspace PRIu64/PRIx64 macros. > > > > For the record, I really hate the inttypes.h format specifiers, but I > > agree that we should forward the example of the C99 spec, for better > > or for worse. > > > > That being said, the userspace PRIu64, et. al macros are complete > > format specifiers, not just a length modifier. And I think this > > results in less ugly format specifiers in our kernel code. > > Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have > the whole format in the PRIino definition -- it /is/ unsigned long > after all. >
Like I said to Ted, this is just temporary scaffolding for the change. The PRIino macro is removed in the end. Given that, perhaps you can overlook the bikeshed's color in this instance? -- Jeff Layton <[email protected]>
