On 1/7/26 13:43, Tvrtko Ursulin wrote: > Now that it is guaranteed there can be no entity if there is no hw ip > block we can remove the open coded protection during CS parsing. > > Signed-off-by: Tvrtko Ursulin <[email protected]> > References: 55414ad5c983 ("drm/amdgpu: error out on entity with no run queue") > Cc: Christian König <[email protected]>
I've gone ahead, reviewed this one here as well and pushed the first two patches into our internal amd-staging-drm-next branch. It should appear public in the next few days if our CI system is happy with it. Thanks, Christian. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index ecdfe6cb36cc..82bb70167f5a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -84,13 +84,6 @@ static int amdgpu_cs_job_idx(struct amdgpu_cs_parser *p, > if (r) > return r; > > - /* > - * Abort if there is no run queue associated with this entity. > - * Possibly because of disabled HW IP. > - */ > - if (entity->rq == NULL) > - return -EINVAL; > - > /* Check if we can add this IB to some existing job */ > for (i = 0; i < p->gang_size; ++i) > if (p->entities[i] == entity)
