Re: [PATCH 1/2] drm/amdgpu: gfx 12.1 cleanups

[Lazar, Lijo]

On 04-Mar-26 8:43 PM, Alex Deucher wrote:
Remove some remnants from when the code was forked
from gfx 12.0.

Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>

One minor comment below for consideration.

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

---
  drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c | 16 ++--------------
  1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c
index 557d15b90ad27..a0ec38f35c449 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c
@@ -3630,12 +3630,6 @@ static int gfx_v12_1_eop_irq(struct amdgpu_device *adev,
                        return -EINVAL;
  
  		switch (me_id) {
-               case 0:
-                       if (pipe_id == 0)
-                               amdgpu_fence_process(&adev->gfx.gfx_ring[0]);
-                       else
-                               amdgpu_fence_process(&adev->gfx.gfx_ring[1]);
-                       break;
                case 1:
                case 2:
                        for (i = 0; i < adev->gfx.num_compute_rings; i++) {
@@ -3652,6 +3646,8 @@ static int gfx_v12_1_eop_irq(struct amdgpu_device *adev,
                                        amdgpu_fence_process(ring);
                        }
                        break;
+               default:


Adding a dev_dbg may be helpful though it's not expected to take this 
path with disable_kq.

Thanks,
Lijo

+                       break;
                }
        }
  
@@ -3720,14 +3716,6 @@ static void gfx_v12_1_handle_priv_fault(struct amdgpu_device *adev,
                return;
  
  	switch (me_id) {
-       case 0:
-               for (i = 0; i < adev->gfx.num_gfx_rings; i++) {
-                       ring = &adev->gfx.gfx_ring[i];
-                       /* we only enabled 1 gfx queue per pipe for now */
-                       if (ring->me == me_id && ring->pipe == pipe_id)
-                               drm_sched_fault(&ring->sched);
-               }
-               break;
        case 1:
        case 2:
                for (i = 0; i < adev->gfx.num_compute_rings; i++) {