Reviewed-by: Christian König <[email protected]> for both.
On 3/4/26 14:09, Khatri, Sunil wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
> Ping
>
> Get Outlook for iOS <https://aka.ms/o0ukef>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Sunil Khatri <[email protected]>
> *Sent:* Tuesday, March 3, 2026 10:41:10 PM
> *To:* Deucher, Alexander <[email protected]>; Koenig, Christian
> <[email protected]>
> *Cc:* [email protected] <[email protected]>; Khatri,
> Sunil <[email protected]>
> *Subject:* [PATCH v1 1/2] drm/amdgpu/userq: remove queue from doorbell xarray
>
> In case of failure in xa_alloc, remove the queue during
> clean up from the userq_doorbell_xa.
>
> Signed-off-by: Sunil Khatri <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 001fcfcbde0f..5224871a099c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -865,6 +865,7 @@ amdgpu_userq_create(struct drm_file *filp, union
> drm_amdgpu_userq *args)
> if (r) {
> drm_file_err(uq_mgr->file, "Failed to allocate a queue
> id\n");
> amdgpu_userq_fence_driver_free(queue);
> + xa_erase_irq(&adev->userq_doorbell_xa, index);
> uq_funcs->mqd_destroy(queue);
> kfree(queue);
> r = -ENOMEM;
> --
> 2.34.1
>
