On 3/6/26 11:24, Sunil Khatri wrote: > linux/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2358:24: warning: format string > is not a string literal (potentially insecure) [-Wformat-security] > sprintf(ring->name, amdgpu_sw_ring_name(i)); > ^~~~~~~~~~~~~~~~~~~~~~ > linux/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2358:24: note: treat the string > as an argument to avoid this > sprintf(ring->name, amdgpu_sw_ring_name(i)); > > Signed-off-by: Sunil Khatri <[email protected]>
Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > index 7e9d753f4a80..95be105671ec 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c > @@ -2355,7 +2355,7 @@ static int gfx_v9_0_sw_init(struct amdgpu_ip_block > *ip_block) > for (i = 0; i < GFX9_NUM_SW_GFX_RINGS; i++) { > ring = &adev->gfx.sw_gfx_ring[i]; > ring->ring_obj = NULL; > - sprintf(ring->name, amdgpu_sw_ring_name(i)); > + strscpy(ring->name, amdgpu_sw_ring_name(i), > sizeof(ring->name)); > ring->use_doorbell = true; > ring->doorbell_index = adev->doorbell_index.gfx_ring0 > << 1; > ring->is_sw_ring = true;
