On 3/17/26 08:47, Jesse.Zhang wrote: > amdgpu_sched_ioctl() currently uses WARN(1, ...) when userspace passes > an out-of-range context priority value. WARN(1, ...) is unconditional > and produces a full stack trace, which is disproportionate for a simple > input validation failure -- the invalid value is already rejected with > -EINVAL on the next line. > > Replace WARN(1, ...) with DRM_ERROR() to log the invalid value at an > appropriate level without generating a stack dump. The -EINVAL return > to userspace is unchanged. > > No functional change for well-formed userspace callers. > > v2: > - Reworked commit message to focus on appropriate log level for > parameter validation > - Clarified that -EINVAL behavior is preserved (Vitaly) > > v3: completely drop that warning. > Invalid parameters should never clutter the system log. (Christian) > > Signed-off-by: Jesse Zhang <[email protected]> > Reviewed-by: Vitaly Prosyak <[email protected]>
Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c > index 341beec59537..0eecfaa3a94c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c > @@ -103,10 +103,8 @@ int amdgpu_sched_ioctl(struct drm_device *dev, void > *data, > return -EINVAL; > } > > - if (!amdgpu_ctx_priority_is_valid(args->in.priority)) { > - WARN(1, "Invalid context priority %d\n", args->in.priority); > + if (!amdgpu_ctx_priority_is_valid(args->in.priority)) > return -EINVAL; > - } > > switch (args->in.op) { > case AMDGPU_SCHED_OP_PROCESS_PRIORITY_OVERRIDE:
