Hi Melissa, Thanks for your answer
On Fri, Mar 20, 2026 at 09:47:47AM -0300, Melissa Wen wrote:
> On 19/03/2026 07:00, Maxime Ripard wrote:
> > Hi Melissa,
> >
> > On Wed, Mar 18, 2026 at 01:27:11PM -0300, Melissa Wen wrote:
> > > For suspend/resume to work correctly, do for colorop state the same we
> > > do for plane/crtc/connector states: duplicate the state of colorops in a
> > > color pipeline if it's in use by a given plane when suspending and
> > > restore cached colorop states when resuming.
> > >
> > > Fixes: 2afc3184f3b3 ("drm/plane: Add COLOR PIPELINE property")
> > > Reviewed-by: Harry Wentland <[email protected]>
> > > Reviewed-by: Alex Hung <[email protected]>
> > > Reviewed-by: Chaitanya Kumar Borah <[email protected]>
> > > Signed-off-by: Melissa Wen <[email protected]>
> > Only slightly related to this patch itself, so this discussion must not
> > block merging this patch.
> >
> > I've been looking at revamping the state allocation / reset recently and
> > came across the colorop. It's not clear to me if it's something that
> > should be expected to be reset across a suspend/resume cycle or if it's
> > something that should be maintained across that cycle.
> >
> > What is your opinion on that?
>
> I understand colorop should follow the same lifecycle of plane, since
> colorop
> is associated with a plane and represent the color configuration of a given
> plane state.
>
> So, I think it should be preserved and restored in a suspend/resume cycle.
Ack :)
> You mentioned about "revamping state allocation/reset", is there already a
> public link for this work that I can take a look?
Sure, it's there:
https://lore.kernel.org/r/[email protected]
I should send a v2 soon though. Do you want to be in Cc?
Maxime
signature.asc
Description: PGP signature
