On Fri, Mar 20, 2026 at 10:42 AM Louis Chauvet
<[email protected]> wrote:
>
> On Fri, 13 Mar 2026 07:19:58 -0600, Jim Cromie <[email protected]> wrote:
> > diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst 
> > b/Documentation/admin-guide/dynamic-debug-howto.rst
> > index 0a42b9de55ac..734be0b5fe9a 100644
> > --- a/Documentation/admin-guide/dynamic-debug-howto.rst
> > +++ b/Documentation/admin-guide/dynamic-debug-howto.rst
> > @@ -218,6 +211,25 @@ line
> > [ ... skip 13 lines ... ]
> > +
> > +.. note::
> > +
> > +    Unlike other keywords, classes are "name-to-change", not
> > +    "omitting-constraint-allows-change".  See Dynamic Debug Classmaps
> > +
>
> Why did you move the class description?
> Is there a way to add a link to _dyndbg-classmaps? (I don't know well the
> rst syntax)

I think I moved it to the bottom cuz its the latest keyword, and the
longest description.
(theyre not alphabetical, they could be, should they be ?)


>
> > @@ -395,3 +412,98 @@ just a shortcut for ``print_hex_dump(KERN_DEBUG)``.
> > [ ... skip 45 lines ... ]
> > +DYNAMIC_DEBUG_CLASSMAP_DEFINE(clname,type,_base,classnames) - this maps
> > +classnames (a list of strings) onto class-ids consecutively, starting
> > +at _base.
> > +
> > +DYNAMIC_DEBUG_CLASSMAP_USE(clname) & _USE_(clname,_base) - modules
> > +call this to refer to the var _DEFINEd elsewhere (and exported).
>
> (if you reorder the patches to merge the "basic" stuff, don't forget to
> move the _USE_ and offset explaination in a second documentation patch)
>
> Reviewed-by: Louis Chauvet <[email protected]>
>
> --
> Louis Chauvet <[email protected]>

Reply via email to