On Fri, Mar 20, 2026 at 10:41 AM Louis Chauvet
<[email protected]> wrote:
>
> On Fri, 13 Mar 2026 07:19:41 -0600, Jim Cromie <[email protected]> wrote:
> > diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
> > index 9fd36339db52..b84518b70a6e 100644
> > --- a/include/linux/dynamic_debug.h
> > +++ b/include/linux/dynamic_debug.h
> > @@ -83,30 +83,42 @@ enum class_map_type {
> > [ ... skip 3 lines ... ]
> > -struct ddebug_class_map {
> > - struct module *mod;
> > - const char *mod_name; /* needed for builtins */
> > +struct _ddebug_class_map {
> > + struct module *mod; /* NULL for builtins */
> > + const char *mod_name;
>
> mod_name is not needed for builtins anymore?
it is needed still for builtins, because the mod ptr is null,
which can supply mod_name for loadable modules.
I can restore the comment if you think its still helpful / not redundant.
>
> > @@ -125,8 +137,8 @@ struct ddebug_class_param {
> > */
> > #define DECLARE_DYNDBG_CLASSMAP(_var, _maptype, _base, ...) \
> > static const char *_var##_classnames[] = { __VA_ARGS__ }; \
> > - static struct ddebug_class_map __aligned(8) __used \
> > - __section("__dyndbg_classes") _var = { \
> > + static struct _ddebug_class_map __aligned(8) __used \
>
> Maybe a dumb question: in a previous patch you added ALIGN(8) for the same
> __section, both are really needed?
its a different macro, so I think it is needed.
Note that the macro is deprecated, and will be removed
as soon as DRM uses are dropped.
>
> >
> > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> > index cb7bfe8729a7..f47fdb769d7a 100644
> > --- a/lib/dynamic_debug.c
> > +++ b/lib/dynamic_debug.c
> > @@ -1254,18 +1255,18 @@ static void ddebug_attach_module_classes(struct
> > ddebug_table *dt, struct _ddebug
> > [ ... skip 13 lines ... ]
> > }
> > }
> > if (nc) {
> > - dt->num_classes = nc;
> > + dt->info.maps.len = nc;
> > vpr_info("module:%s attached %d classes\n", dt->mod_name, nc);
>
> IIUC, maps and classes are the same thing, can you do a s/classes/maps/ in
> the vpr_*?
yes - class_maps is probably clearest - closest match to code too.
>
> --
> Louis Chauvet <[email protected]>
