On Tue, May 05, 2026 at 10:32:57AM -0500, Mario Limonciello wrote: > > > On 5/5/26 06:41, Hamza Mahfooz wrote: > > On Mon, May 04, 2026 at 04:50:21PM -0500, Mario Limonciello wrote: > > > Do you actually need to set all 3 of these to true? > > > > > > I would think you only need: > > > > > > crtc_state->mode_changed = true; > > > > > > > According to my testing `mode_changed` on it's own is sufficient for > > amdgpu and the documentation [1] seems to suggest that it should be fine > > more broadly. Though, it doesn't seem harmful to set all of them just > > for safe measure. > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/drm/drm_crtc.h?h=v7.1-rc2#n118 > > My main concern was it's safe right now, but what if future changes to > atomic control flow mean it executes more code paths than needed; or worse > unexpected code paths.
Point taken, I'll respin this with them removed.
