On 5/5/26 18:20, Alex Hung wrote:
> From: Harry Wentland <[email protected]>
>
> The depends on !UML was added in commit dffe68131707 ("amdgpu: Avoid
> building on UML") to work around build failures with allyesconfig on
> UML. The original errors were:
>
> - smu7_hwmgr.c: incompatible pointer type 'struct cpuinfo_um *' vs
> 'struct cpuinfo_x86 *' in intel_core_rkl_chk()
> - kfd_topology.c: 'struct cpuinfo_um' has no member named 'apicid'
>
> Both issues have since been resolved independently:
> - intel_core_rkl_chk() has been removed entirely.
> - kfd_topology.c now uses a proper #ifdef CONFIG_X86_64 guard.
> - All other cpuinfo_x86/cpu_data() references in the driver are
> guarded by #if IS_ENABLED(CONFIG_X86) or #ifdef CONFIG_X86_64.
>
> Removing this exclusion allows CONFIG_DRM_AMDGPU to be selected on UML,
> which in turn enables running KUnit tests (such as amdgpu_dm_crc_test)
> under UML without needing a full hardware-capable kernel build.
Looks like a good idea but there are 5 automated reports from kernel test
robots that the patch causes issues.
It could be that the robots apply the patch to the wrong tree, but please
double check.
With that done the patch is Reviewed-by: Christian König
<[email protected]>
Regards,
Christian.
>
> Reviewed-by: Alex Hung <[email protected]>
> Assisted-by: Claude:claude-opus-4.6
> Signed-off-by: Harry Wentland <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 0d4ce2ef9da6..49a7360f45ce 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -3,7 +3,6 @@
> config DRM_AMDGPU
> tristate "AMD GPU"
> depends on DRM && PCI
> - depends on !UML
> select FW_LOADER
> select DRM_CLIENT
> select DRM_CLIENT_SELECTION
> --
> 2.43.0
>
