On Mon, May 25, 2026 at 11:49 AM Jeevana Muthyala <[email protected]> wrote: > > Set secure_submission_supported = true for the VCN unified ring funcs in > vcn_v4_0_5.c so secure IBs are allowed on the unifiedring. > Without this, protected decode submissions are blocked by the > common IB gate and can fail playback for secure content. > > For vcn_v4_0_5.c (fixed STX VCN version), secure submission is > enabled directly in the ring funcs definition. > > This change only advertises existing hardware/firmware capability; > non-secure decode paths are unaffected. > > Signed-off-by: Jeevana Muthyala <[email protected]>
Series is: Acked-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c > b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c > index 1571cc5a148c..c8879a6e5297 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c > @@ -1479,10 +1479,11 @@ static int vcn_v4_0_5_ring_reset(struct amdgpu_ring > *ring, > return amdgpu_ring_reset_helper_end(ring, timedout_fence); > } > > -static struct amdgpu_ring_funcs vcn_v4_0_5_unified_ring_vm_funcs = { > +static const struct amdgpu_ring_funcs vcn_v4_0_5_unified_ring_vm_funcs = { > .type = AMDGPU_RING_TYPE_VCN_ENC, > .align_mask = 0x3f, > .nop = VCN_ENC_CMD_NO_OP, > + .secure_submission_supported = true, > .no_user_fence = true, > .get_rptr = vcn_v4_0_5_unified_ring_get_rptr, > .get_wptr = vcn_v4_0_5_unified_ring_get_wptr, > @@ -1525,9 +1526,6 @@ static void vcn_v4_0_5_set_unified_ring_funcs(struct > amdgpu_device *adev) > if (adev->vcn.harvest_config & (1 << i)) > continue; > > - if (amdgpu_ip_version(adev, VCN_HWIP, 0) == IP_VERSION(4, 0, > 5)) > - > vcn_v4_0_5_unified_ring_vm_funcs.secure_submission_supported = true; > - > adev->vcn.inst[i].ring_enc[0].funcs = > &vcn_v4_0_5_unified_ring_vm_funcs; > adev->vcn.inst[i].ring_enc[0].me = i; > } > -- > 2.43.0 >
