Re: [PATCH v3] drm/amd/pm: Stop pp_od_clk_voltage emit at PAGE_SIZE

[Lazar, Lijo]

On 03-Jun-26 12:46 PM, Asad Kamal wrote:

Stop appending OD sections in amdgpu_get_pp_od_clk_voltage()
once the sysfs page is full, instead of checking every sysfs_emit_at()
in SMU helpers. This is purely defensive hardening.

v2: Drop the prior series that checked sysfs_emit_at()
return values in every SMU *_emit_clk_levels() helper and
smu_cmn_print_*().(Kevin)

v3: Update description, remove all clamping

Signed-off-by: Asad Kamal <asad.ka...@amd.com>
Reviewed-by: Yang Wang <kevinyang.w...@amd.com>

Reviewed-by: Lijo Lazar <lijo.la...@amd.com>

Thanks,
Lijo

---
  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 1e590db80221..85bef52887d2 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -874,6 +874,8 @@ static ssize_t amdgpu_get_pp_od_clk_voltage(struct device 
*dev,

for (clk_index = 0 ; clk_index < ARRAY_SIZE(od_clocks) ; clk_index++) {

                amdgpu_dpm_emit_clock_levels(adev, od_clocks[clk_index], buf, 
&size);
+               if (unlikely(size >= (PAGE_SIZE - 1)))
+                       break;
        }

if (size == 0)