On 6/10/26 12:03, Priya Hosur wrote:
On 6/10/26 08:29, Lazar, Lijo wrote:
These are clocks for the second VCN instance. If adding them to FW
metrics is not an option, then reporting the value as UINT_MAX is
better as that indicates N/A (not applicable/available).
Agreed, I'll drop the VCLK1/DCLK1 handlers and let them fall through
to the default (UINT_MAX / N/A) in v2.
Do the two instances share a common clock?
On v14.0.0, there is a single VCN instance where VCLK and DCLK share
the same clock domain -- the DPM table comment in smu14_driver_if says
"Applies to both Vclk and Dclk". So mapping METRICS_AVERAGE_DCLK to
VclkFrequency is correct here.
On v14.0.1, there are two VCN instances (Vcn0/Vcn1) with separate
clock domains, but SmuMetrics_t only exposes VclkFrequency for
instance 0. There are no fields for DCLK, VCLK1, or DCLK1 in the
firmware metrics struct.
Then I agree with Lijo's suggestion that it should continue to be N/A
for second instance.
