Re: [PATCH v2 1/4] drm/amd/pm: smu_v14_0_0: add DCLK metric handler via VCLK fall-through

[Lazar, Lijo]

On 10-Jun-26 11:53 PM, Priya Hosur wrote:
Merge METRICS_AVERAGE_VCLK and METRICS_AVERAGE_DCLK into a single
fall-through case mapping both to VclkFrequency, since SmuMetrics_t
has no DclkFrequency field and DCLK tracks VCLK on VCN.

Signed-off-by: Priya Hosur <priya.ho...@amd.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
index 2fe006de927a..79e0e2fca602 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
@@ -281,10 +281,9 @@ static int smu_v14_0_0_get_smu_metrics_data(struct 
smu_context *smu,
                *value = metrics->SocclkFrequency;
                break;
        case METRICS_AVERAGE_VCLK:
-               *value = metrics->VclkFrequency;
-               break;
        case METRICS_AVERAGE_DCLK:
-               *value = 0;
+               /* No DclkFrequency in SmuMetrics_t; DCLK tracks VCLK on VCN */
+               *value = metrics->VclkFrequency;

The code refers to separate clock tables for DCLK and VCLK. As per this 
they are identical, but still fetched separately.

Thanks,
Lijo

                break;
        case METRICS_AVERAGE_UCLK:
                *value = metrics->MemclkFrequency;