AMD General

Reviewed-by: Yang Wang <[email protected]>

Best Regards,
Kevin

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of Srinivasan
> Shanmugam
> Sent: Thursday, June 25, 2026 12:58
> To: Koenig, Christian <[email protected]>; Deucher, Alexander
> <[email protected]>
> Cc: [email protected]; SHANMUGAM, SRINIVASAN
> <[email protected]>; Wang, Yang(Kevin)
> <[email protected]>; Zhang, Hawking <[email protected]>
> Subject: [PATCH] drm/amdgpu/powerplay: Align get_tonga_state_array() header 
> with
> prototype
>
> The function header above get_tonga_state_array() still refers to
> check_powerplay_tables() and does not describe all of the function parameters.
>
> Update it to match the current function prototype and include the missing 
> parameter
> description.
>
> Fixes: 8c8c4544cc43 ("drm/amd/pm: Validate Tonga PowerPlay state array 
> bounds")
> Cc: Yang Wang <[email protected]>
> Cc: Hawking Zhang <[email protected]>
> Signed-off-by: Srinivasan Shanmugam <[email protected]>
> ---
>  .../gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> index 17d5bb62e3db..0d6d711b4995 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> @@ -1546,11 +1546,12 @@ static int init_thermal_controller(  }
>
>  /**
> - * check_powerplay_tables - Private Function used during initialization.
> - * Inspect the PowerPlay table for obvious signs of corruption.
> + * get_tonga_state_array - Get the Tonga state array from the PowerPlay 
> table.
>   * @hwmgr: Pointer to the hardware manager.
>   * @powerplay_table: Pointer to the PowerPlay Table.
> - * Exception:  2 if the powerplay table is incorrect.
> + * @state_array: Pointer to the returned Tonga state array.
> + *
> + * Return: 0 on success, negative error code on failure.
>   */
>  static int get_tonga_state_array(struct pp_hwmgr *hwmgr,
>       const ATOM_Tonga_POWERPLAYTABLE *powerplay_table,
> --
> 2.34.1

Reply via email to