On 2026. június 26., péntek 10:55:56 közép-európai nyári idő Tvrtko Ursulin wrote: > This function is unused so lets remove it. > > Signed-off-by: Tvrtko Ursulin <[email protected]> > Cc: Alex Deucher <[email protected]> > Cc: Christian König <[email protected]> > Cc: Timur Kristóf <[email protected]>
Nice cleanup! Reviewed-by: Timur Kristóf <[email protected]> Are there any more uses left of the amdgpu_ip_block_status.hw field? As far as I can see the field is set but never used, maybe we could remove it too. What did this field mean anyway? Best regards, Timur > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c | 21 --------------------- > drivers/gpu/drm/amd/amdgpu/amdgpu_ip.h | 2 -- > 2 files changed, 23 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c index 6aa54156bbc9..62285e973c5c > 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c > @@ -368,27 +368,6 @@ int amdgpu_device_ip_wait_for_idle(struct amdgpu_device > *adev, return 0; > } > > -/** > - * amdgpu_device_ip_is_hw - is the hardware IP enabled > - * > - * @adev: amdgpu_device pointer > - * @block_type: Type of hardware IP (SMU, GFX, UVD, etc.) > - * > - * Check if the hardware IP is enable or not. > - * Returns true if it the IP is enable, false if not. > - */ > -bool amdgpu_device_ip_is_hw(struct amdgpu_device *adev, > - enum amd_ip_block_type block_type) > -{ > - struct amdgpu_ip_block *ip_block; > - > - ip_block = amdgpu_device_ip_get_ip_block(adev, block_type); > - if (ip_block) > - return ip_block->status.hw; > - > - return false; > -} > - > /** > * amdgpu_device_ip_is_valid - is the hardware IP valid > * > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.h > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.h index 1d0df6d93957..11739fbdeaa6 > 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ip.h > @@ -146,8 +146,6 @@ void amdgpu_device_ip_get_clockgating_state(struct > amdgpu_device *adev, u64 *flags); > int amdgpu_device_ip_wait_for_idle(struct amdgpu_device *adev, > enum amd_ip_block_type block_type); > -bool amdgpu_device_ip_is_hw(struct amdgpu_device *adev, > - enum amd_ip_block_type block_type); > bool amdgpu_device_ip_is_valid(struct amdgpu_device *adev, > enum amd_ip_block_type block_type);
