On Fri, Jun 26, 2026 at 10:54 AM <[email protected]> wrote: > > From: Boyuan Zhang <[email protected]> > > jpeg_v5_0_1_is_idle() initializes ret to false and then accumulates ring > idle status using &=. Since false & condition always remains false, the > function can never report the JPEG block as idle. > > Initialize ret to true so the function returns true only when all JPEG > rings report RB_JOB_DONE. > > Signed-off-by: Boyuan Zhang <[email protected]> > Reviewed-by: David (Ming Qiang) Wu <[email protected]>
Series is: Reviewed-by: Alex Deucher <[email protected]> Fixes: tags would be nice. Thanks, Alex > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c > b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c > index a562369d2d81..01cafa6a4fed 100644 > --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c > +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c > @@ -674,7 +674,7 @@ static void jpeg_v5_0_1_dec_ring_set_wptr(struct > amdgpu_ring *ring) > static bool jpeg_v5_0_1_is_idle(struct amdgpu_ip_block *ip_block) > { > struct amdgpu_device *adev = ip_block->adev; > - bool ret = false; > + bool ret = true; > int i, j; > > for (i = 0; i < adev->jpeg.num_jpeg_inst; ++i) { > -- > 2.43.0 >
