On 2026-07-01 13:00, Mario Limonciello wrote:
> Add kernel-doc references for amdgpu_display.c to the display manager
> documentation. This pulls in documentation for display core functions
> like the hotplug work handler, and the adaptive backlight modulation
> property.
> 
> The :internal: directive automatically includes all function documentation,
> while the explicit :doc: directive captures the property documentation that
> :internal: doesn't pull in.
> 
> Fixes: 1454642960b0a ("drm/amd: Re-introduce property to control adaptive 
> backlight modulation")
> Signed-off-by: Mario Limonciello <[email protected]>
> ---
>  Documentation/gpu/amdgpu/display/display-manager.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/gpu/amdgpu/display/display-manager.rst 
> b/Documentation/gpu/amdgpu/display/display-manager.rst
> index b269ff3f7a545..4584a3fa48155 100644
> --- a/Documentation/gpu/amdgpu/display/display-manager.rst
> +++ b/Documentation/gpu/amdgpu/display/display-manager.rst
> @@ -178,3 +178,15 @@ following path:
>  2. On DC interface, :c:type:`struct mpcc_blnd_cfg <mpcc_blnd_cfg>` programs 
> the
>     MPCC blend configuration considering the :c:type:`dc_plane_info
>     <dc_plane_info>` input from DPP.
> +
> +Display Core
> +============
> +
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +   :internal:
> +

Since this only adds the doc for hotplug_work_func(), it would make more sense 
to 
append under the "Interrupts" section as:

.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
   :functions: amdgpu_display_hotplug_work_func

With that,

Reviewed-by: Leo Li <[email protected]>

> +Display Properties
> +==================
> +
> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +   :doc: property for adaptive backlight modulation

Reply via email to