On 13/07/2026 13:58, Timur Kristóf wrote:
Return an error code instead of silently failing.
Signed-off-by: Timur Kristóf <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
index a1a9f3fc4567..0ceadb107d26 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
@@ -2576,7 +2576,10 @@ static int gfx_v7_0_cp_gfx_resume(struct amdgpu_device
*adev)
WREG32(mmCP_RB0_BASE_HI, upper_32_bits(rb_addr));
/* start the ring */
- gfx_v7_0_cp_gfx_start(adev);
+ r = gfx_v7_0_cp_gfx_start(adev);
+ if (r)
+ return r;
+
r = amdgpu_ring_test_helper(ring);
if (r)
return r;
Hm this one looks less "controversial" than the previous one since it
already can error out. And surely test ring helper would error out if
cp_gfx_start failed..
I think it also means the previous one is likely fine.
Reviewed-by: Tvrtko Ursulin <[email protected]>
Regards,
Tvrtko
