amdgpu_userq_wait_return_fence_info() calls drm_exec_init() without
DRM_EXEC_IGNORE_DUPLICATES. When the same GEM object appears more than
once across the read/write BO handle lists submitted by userspace,
drm_exec_lock_obj() returns -EALREADY the second time it locks that
object, which aborts the fence resolution pass instead of treating the
repeat as a no-op.

Add DRM_EXEC_IGNORE_DUPLICATES so duplicate objects are silently
skipped on the second lock attempt.

Signed-off-by: Sunil Khatri <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 433187df04f3..19af1adc2921 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -814,7 +814,7 @@ amdgpu_userq_wait_return_fence_info(struct drm_device *dev, 
struct drm_file *fil
        /* Lock all the GEM objects */
        num_read_bo_handles = wait_info->num_bo_read_handles;
        num_write_bo_handles = wait_info->num_bo_write_handles;
-       drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT,
+       drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT | 
DRM_EXEC_IGNORE_DUPLICATES,
                      num_read_bo_handles + num_write_bo_handles);
 
        drm_exec_until_all_locked(&exec) {
-- 
2.34.1

Reply via email to