AMD General Sure, will improve it.
Best Regards, Liu, Xiang ________________________________ From: Zhou1, Tao <[email protected]> Sent: Monday, August 24, 2026 10:41 AM To: Liu, Xiang(Dean) <[email protected]>; [email protected] <[email protected]> Cc: Zhang, Hawking <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas <[email protected]> Subject: RE: [PATCH 1/2] drm/amd/ras: tolerate an unsupported MCA debug mode control AMD General > -----Original Message----- > From: Liu, Xiang(Dean) <[email protected]> > Sent: Saturday, August 22, 2026 6:26 PM > To: [email protected] > Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao > <[email protected]>; Yang, Stanley <[email protected]>; Chai, Thomas > <[email protected]>; Liu, Xiang(Dean) <[email protected]> > Subject: [PATCH 1/2] drm/amd/ras: tolerate an unsupported MCA debug mode > control > > ras_mp1_set_debug_mode() reports -EOPNOTSUPP where the control does not > exist, an SR-IOV guest among them. Treating that as fatal fails > ras_core_sw_init() and takes RAS down on every VF. > > Nothing else in the MP1 block depends on it, so carry on. [Tao] you can also add this explanation as code comment, anyway, the series is: Reviewed-by: Tao Zhou <[email protected]> > > Signed-off-by: Xiang Liu <[email protected]> > --- > drivers/gpu/drm/amd/ras/core/ras_mp1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/ras/core/ras_mp1.c > b/drivers/gpu/drm/amd/ras/core/ras_mp1.c > index 2452448806f6..781faf6a7529 100644 > --- a/drivers/gpu/drm/amd/ras/core/ras_mp1.c > +++ b/drivers/gpu/drm/amd/ras/core/ras_mp1.c > @@ -203,12 +203,12 @@ int ras_mp1_sw_init(struct ras_core_context *ras_core) > mutex_init(&mp1->op_mutex); > > ret = ras_mp1_set_debug_mode(ras_core, false); > - if (ret) { > + if (ret && ret != -EOPNOTSUPP) { > mutex_destroy(&mp1->op_mutex); > return ret; > } > > - return ret; > + return 0; > } > > int ras_mp1_sw_fini(struct ras_core_context *ras_core) > -- > 2.34.1
