On 23/07/2026 22.13, Fangzhi Zuo wrote:
From: Clay King <[email protected]>
[Why]
The MPCCs different gamut remap matrices allow for S2D13 and S3D12 floating
point formats, but only S2D13 is used. There may be cases where more
integer bits are required.
[How]
Switch to S3D12 if any entries in the remap matrix cannot fit in S2D13.
Otherwise, prefer the extra precision of S2D13. Communicate the max value
that hw can support to dm via dc color caps.
Reviewed-by: Dillon Varone <[email protected]>
Signed-off-by: Clay King <[email protected]>
Signed-off-by: Fangzhi Zuo <[email protected]>
Tested-by: Dan Wheeler <[email protected]>
---
...
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 75c06a1752b5..07ebd98f0d3b 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -315,6 +315,7 @@ struct mpc_color_caps {
struct lut3d_caps mcm_3d_lut_caps;
struct lut3d_caps rmcm_3d_lut_caps;
bool preblend;
+ struct fixed31_32 max_gamut_remap_coeff;
};
Hi!
FYI, this change is causing a warning during "make htmldocs" now:
WARNING: ..../drivers/gpu/drm/amd/display/dc/dc.h:327 struct member
'max_gamut_remap_coeff' not described in 'mpc_color_caps'
Could you maybe sent a patch to document it in the kerneldoc comment when
you've got some spare time?
Thanks,
Thomas
