On Tuesday, September 22, 2026 5:32:12 PM Central European Summer Time James Zhu wrote: > On 2026-09-22 11:22, Timur Kristóf wrote: > > On Tuesday, September 22, 2026 5:20:41 PM Central European Summer Time > > James> > > Zhu wrote: > >> On 2026-09-22 11:09, Timur Kristóf wrote: > >>> On Monday, September 21, 2026 10:03:02 PM Central European Summer Time > >>> James> > >>> > >>> Zhu wrote: > >>>> Add the DRM_AMDGPU_PROFILER ioctl number and its argument structures, > >>>> the > >>>> UAPI for GPU performance monitoring features such as SPM (Stream > >>>> Performance Monitor). > >>>> > >>>> struct drm_amdgpu_profiler_args carries an operation selector and a > >>>> union > >>>> of per-operation parameters, currently AMDGPU_PROFILER_OP_GET_VER and > >>>> AMDGPU_PROFILER_OP_SPM. The SPM operations and the layout of the > >>>> destination buffer are described by struct drm_amdgpu_spm_args and > >>>> struct drm_amdgpu_spm_buffer_header. > >>>> > >>>> The ioctl number and struct layout are frozen here. The implementation > >>>> lands in the rest of this series and the ioctl is not registered in > >>>> amdgpu_ioctls_kms[] until then, so this header change alone does not > >>>> make > >>>> the interface reachable. > >>>> > >>>> Signed-off-by: James Zhu<[email protected]> > >>>> Reviewed-by: Bing Ma<[email protected]> > >>> > >>> Hi, > >>> > >>> Can you guys please clarify why this is necessary and what the use case > >>> is? > >>> > >>> Are we sure we want a uAPI for this? RADV has been using SPM from > >>> userspace > >>> for many years now. > >> > >> [JZ] current RADV SPM is for graphic engine. These patches are for > >> compute engine SPM. > >> > >> Thanks! > > > > Is there any reason why it can't be done in userspace for compute too? > > [JZ] for compute engine, user space is using ROCM stack , not RADV.
Is there any reason why SPM can't be handled from userspace? (Regardless of whether that userspace is RADV or ROCm)
