On 24/09/2026 22:10, Melissa Wen wrote:
The prev_p_state_change_support trace entry is assigned and printed
twice, remove the unnecessary duplicates.
Fixes: 13b5ca42ca9c ("drm/amd/display: Add tracepoint for capturing clocks
state")
Signed-off-by: Melissa Wen <[email protected]>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
index cc70aeb75798..887ebac8c97e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
@@ -523,7 +523,6 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
__entry->p_state_change_support =
clk->p_state_change_support;
__entry->prev_p_state_change_support =
clk->prev_p_state_change_support;
__entry->pwr_state = clk->pwr_state;
- __entry->prev_p_state_change_support =
clk->prev_p_state_change_support;
__entry->dtm_level = clk->dtm_level;
__entry->max_supported_dppclk_khz =
clk->max_supported_dppclk_khz;
__entry->max_supported_dispclk_khz =
clk->max_supported_dispclk_khz;
@@ -533,8 +532,8 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
TP_printk("dispclk_khz=%d dppclk_khz=%d disp_dpp_voltage_level_khz=%d
dcfclk_khz=%d socclk_khz=%d "
"dcfclk_deep_sleep_khz=%d fclk_khz=%d phyclk_khz=%d "
"dramclk_khz=%d p_state_change_support=%d "
- "prev_p_state_change_support=%d pwr_state=%d
prev_p_state_change_support=%d "
- "dtm_level=%d max_supported_dppclk_khz=%d
max_supported_dispclk_khz=%d "
+ "prev_p_state_change_support=%d pwr_state=%d dtm_level=%d
"
+ "max_supported_dppclk_khz=%d max_supported_dispclk_khz=%d
"
"bw_dppclk_khz=%d bw_dispclk_khz=%d ",
__entry->dispclk_khz,
__entry->dppclk_khz,
@@ -548,7 +547,6 @@ TRACE_EVENT(amdgpu_dm_dc_clocks_state,
__entry->p_state_change_support,
__entry->prev_p_state_change_support,
__entry->pwr_state,
- __entry->prev_p_state_change_support,
__entry->dtm_level,
__entry->max_supported_dppclk_khz,
__entry->max_supported_dispclk_khz,
Reviewed-by: Tvrtko Ursulin <[email protected]>
Regards,
Tvrtko
